Use encoding TextMarshaler & TextUnmarshaler instead of JSON equivalents
#95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
commented
May 18, 2022
| v.si = temp.si | ||
| v.original = temp.original | ||
|
|
||
| *v = *temp |
There was a problem hiding this comment.
This allows us to just copy the whole content of the struct without having to explicitly list out all fields.
|
Interesting, thanks for the cc and explanation! |
jukie
suggested changes
May 18, 2022
|
Technically the tests are still testing JSON marshaling/unmarshaling, which is probably the most common use case and AFAICT there isn't equivalent of |
jukie
approved these changes
May 18, 2022
mdeggies
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically quoted string is valid JSON, but in the context of go-version we deal with single line of text being serialized or unserialized, not structures which are more common for JSON or YAML.
Implementing
encoding.TextMarshalerandencoding.TextUnmarshalerretains the same functionality (as demonstrated by existing passing tests) sincejson.Marshalandjson.Unmarshalwill both reflect that interface and makes it work for other formats, such as YAML.cc @jukie