Add json handlers #93
Conversation
|
|
version_test.go
Outdated
| {"1.2.3", false}, | ||
| {"1.2.0-x.Y.0+metadata", false}, | ||
| {"1.2.0-x.Y.0+metadata-width-hypen", false}, | ||
| {"1.2.3-rc1-with-hypen", false}, | ||
| {"1.2.3.4", false}, | ||
| {"1.2.0.4-x.Y.0+metadata", false}, | ||
| {"1.2.0.4-x.Y.0+metadata-width-hypen", false}, | ||
| {"1.2.0-X-1.2.0+metadata~dist", false}, | ||
| {"1.2.3.4-rc1-with-hypen", false}, | ||
| {"1.2.3.4", false}, |
There was a problem hiding this comment.
Not sure what values would make sense to force a failure here.
There was a problem hiding this comment.
Hi @jukie,
Thanks for submitting this PR. I don't see much benefit in negative tests here because errors are only returned by code that's not specifically under test by this test function (the standard library json package and the parsing by NewVersion()). The code that really needs to be tested in your implementation is the transfer of data from the temporary struct to the receiver, and I think the tests you already have cover that logic.
mdeggies
requested review from
a team,
shore and
mdeggies
and removed request for
a team
|
@shore looks like I pushed an incomplete commit. Sorry about that, should be actually ready now. |
|
@shore any chance I could also request for a release cut in the next couple weeks? |
Closes #94
This adds two functions that implement JSON.Unmarshaler and JSON.Marshaler interface to allow for parsing to/from json.