Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ListEffectiveTagBindings to Workspaces/Projects #996

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

brandonc
Copy link
Collaborator

Test results

$ ENABLE_BETA=1 go test ./... -v -run "Test(Projects|Workspaces)Update/with_valid_options"
?       github.com/hashicorp/go-tfe/examples/backing_data       [no test files]
?       github.com/hashicorp/go-tfe/examples/configuration_versions     [no test files]
?       github.com/hashicorp/go-tfe/examples/organizations      [no test files]
?       github.com/hashicorp/go-tfe/examples/registry_modules   [no test files]
?       github.com/hashicorp/go-tfe/examples/run_errors [no test files]
?       github.com/hashicorp/go-tfe/examples/state_versions     [no test files]
?       github.com/hashicorp/go-tfe/examples/users      [no test files]
?       github.com/hashicorp/go-tfe/examples/workspaces [no test files]
?       github.com/hashicorp/go-tfe/mocks       [no test files]
=== RUN   TestProjectsUpdate
=== RUN   TestProjectsUpdate/with_valid_options
--- PASS: TestProjectsUpdate (2.42s)
    --- PASS: TestProjectsUpdate/with_valid_options (1.55s)
=== RUN   TestWorkspacesUpdate
=== RUN   TestWorkspacesUpdate/with_valid_options
--- PASS: TestWorkspacesUpdate (3.43s)
    --- PASS: TestWorkspacesUpdate/with_valid_options (0.99s)
=== RUN   TestWorkspacesUpdateTableDriven
--- PASS: TestWorkspacesUpdateTableDriven (1.31s)
=== RUN   TestWorkspacesUpdateTableDrivenWithGithubApp
    workspace_integration_test.go:1654: Export a valid GITHUB_APP_INSTALLATION_ID before running this test!
--- SKIP: TestWorkspacesUpdateTableDrivenWithGithubApp (0.00s)
=== RUN   TestWorkspacesUpdateByID
=== RUN   TestWorkspacesUpdateByID/with_valid_options
--- PASS: TestWorkspacesUpdateByID (1.80s)
    --- PASS: TestWorkspacesUpdateByID/with_valid_options (0.51s)
=== RUN   TestWorkspacesUpdateWithDefaultExecutionMode
--- PASS: TestWorkspacesUpdateWithDefaultExecutionMode (1.85s)
PASS
ok      github.com/hashicorp/go-tfe     11.302s

Copy link
Contributor

@ctrombley ctrombley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@@ -135,6 +135,10 @@ type Workspaces interface {
// ListTagBindings lists all tag bindings associated with the workspace.
ListTagBindings(ctx context.Context, workspaceID string) ([]*TagBinding, error)

// ListEffectiveTagBindings lists all tag bindings associated with the workspace which may be
// either inherited from a project or binded to the workspace itself.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/binded/bound/

@brandonc brandonc merged commit d388f7e into main Nov 4, 2024
7 checks passed
@brandonc brandonc deleted the TF-21917-go-tfe-support-for-effective-tag-bindings branch November 4, 2024 16:41
Copy link

github-actions bot commented Nov 4, 2024

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants