Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes NewRequest strips query from path parameter #982

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

brandonc
Copy link
Collaborator

@brandonc brandonc commented Sep 25, 2024

Fixes a bug in NewRequest that did not allow query parameters to be specified in the first parameter, which broke several methods: RegistryModules ReadVersion, VariableSets UpdateWorkspaces, and Workspaces Readme

Closes #981

Fixes a bug in `NewRequest` that did not allow query parameters to be specified in the first parameter, which broke several methods: `RegistryModules ReadVersion`, `VariableSets UpdateWorkspaces`, and `Workspaces Readme`
Comment on lines +315 to +317
for k, v := range u.Query() {
q[k] = v
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@brandonc brandonc merged commit 0b3525a into main Sep 25, 2024
7 checks passed
@brandonc brandonc deleted the brandonc/allow_newrequest_path_query branch September 25, 2024 20:00
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beginning with 1.63.0, NewRequest strips query params, breaking some callers
2 participants