add DialOptions to GRPCBroker's Dial #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
|
|
|
Closed by #257 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Spiritual successor to : #168
For purpose built client-side interceptors, there can be a need to control which plugins get certain interceptors and this currently isn't possible with
GRPCBroker'sDial(id uint32)signature or using "global" dialOpts in the plugin Client Config struct (without changing existing plugin structures to use multiple client instances)Client-side change
The underlying dial implementation in
Dial(id uint32)accepts...grpc.DialOptionso I propose :Dial(id uint32, dialOpts ...grpc.DialOption)for more fine grained control over GRPCBroker connections.