Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: bump MSV of go to 1.15.13 #325

Merged
merged 1 commit into from
Jun 17, 2021
Merged

CI: bump MSV of go to 1.15.13 #325

merged 1 commit into from
Jun 17, 2021

Conversation

tgross
Copy link
Member

@tgross tgross commented Jun 17, 2021

9e42df5 introduced an Insecure flag for the http getter and in its error
reporting relied on the url.Redacted() method introduced in golang 1.15
(See https://golang.org/doc/go1.15). This breaks CI, but golang 1.14 is out of
support so our minimum supported version of go should now be on the 1.15.x
series.

9e42df5 introduced an `Insecure` flag for the http getter and in its error
reporting relied on the `url.Redacted()` method introduced in golang 1.15
(See https://golang.org/doc/go1.15). This breaks CI, but golang 1.14 is out of
support so our minimum supported version of go should now be on the 1.15.x
series.
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch.

@tgross tgross merged commit af95113 into main Jun 17, 2021
@azr azr deleted the go1.15.13 branch June 18, 2021 08:22
ebudan pushed a commit to ebudan/go-getter that referenced this pull request Jul 22, 2021
9e42df5 introduced an `Insecure` flag for the http getter and in its error
reporting relied on the `url.Redacted()` method introduced in golang 1.15
(See https://golang.org/doc/go1.15). This breaks CI, but golang 1.14 is out of
support so our minimum supported version of go should now be on the 1.15.x
series.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants