Support for BearerAuthorizerCallback with MSAL tokens #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
commented
Nov 29, 2021
| @@ -100,9 +101,9 @@ func (c Config) BuildOAuthConfig(activeDirectoryEndpoint string) (*OAuthConfig, | |||
| return &multiAuth, nil | |||
| } | |||
|
|
|||
| // BearerAuthorizerCallback returns a BearerAuthorizer valid only for the Primary Tenant | |||
| // ADALBearerAuthorizerCallback returns a BearerAuthorizer valid only for the Primary Tenant | |||
There was a problem hiding this comment.
Open to suggestions on naming these and/or whether we can break this exported method?
…from token claims where possible
manicminer
force-pushed
the
feature/bearer-authorizer-callback
branch
from
8f3f5eb
to
daa17c9
Compare
manicminer
added a commit
to hashicorp/terraform-provider-azurerm
that referenced
this pull request
Nov 30, 2021
…on't return a nil function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, use object ID from token claims where possible instead of calling out to AAD Graph or MS Graph. Tokens should always have an
oidclaim but fallback is provided to query a graph API in the event unmarshaling fails or the claim is missing/empty.