AppFrame: Remove withAppHeader argument from SideNav (HDS-3612)
#2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hashibot-hds
added
packages/components
docs-website
2 tasks
KristinLBradley
deleted the
hds-3612-app-frame-updates-remove-with-app-header-arg
branch
KristinLBradley
added a commit
that referenced
this pull request
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
“Enterprise Nav” phase 1.5 updates
📌 Summary
If merged, this PR removes the
withAppHeaderargument from theSideNavcomponent along with related documentation & tests.The
withAppHeaderargument was rendered redundant with refactors made in thehds-3612-app-frame-updatesbranch which this branch points to.🔗 External links
AppFrame: “Enterprise Nav” phase 1.5 updates (HDS-3612) #2299👀 Component checklist
[ ] A changelog entry was added via [Changesets](Will update in parent branch)(https://github.com/changesets/changesets) if needed (see templates here)💬 Please consider using conventional comments when reviewing this PR.