Update Envoy compatibility matrices to include consul 1.20.x and dataplane 1.6.x #21852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathancoleman
added
pr/no-changelog
github-actions
bot
added
the
type/docs
nathancoleman
commented
Oct 17, 2024
| @@ -122,7 +123,6 @@ until the LTS release reaches its end of maintenance. | |||
|
|
|||
| | Consul Version | Default `consul-dataplane` Version | Other compatible `consul-dataplane` Versions | | |||
| | -------------- | -------------------------------------|----------------------------------------------| | |||
| | 1.19.x Ent | 1.5.x (Envoy 1.29.x) | 1.4.x (Envoy 1.28.x) | | |||
There was a problem hiding this comment.
I'm not sure why 1.19 was included in this table of LTS releases, but I removed it
Comment on lines
+111
to
112
| | 1.20.x CE | 1.6.x (Envoy 1.31.x) | 1.5.x (Envoy 1.29.x) | | ||
| | 1.19.x CE | 1.5.x (Envoy 1.29.x) | 1.4.x (Envoy 1.28.x) | |
There was a problem hiding this comment.
We had to jump two versions at some point bc we'd started to lag >1 release on latest Envoy vs. latest Consul due to release cadence differences. 1.20 happened to be selected as the version for the jump.
zalimeni
reviewed
Oct 17, 2024
…that span versions
nathancoleman
commented
Oct 17, 2024
Comment on lines
-139
to
-140
| | 1.5.0 - 1.5.latest | 1.18.x Ent | Envoy 1.29.x | | ||
| | 1.4.0 - 1.4.latest | 1.18.x Ent | Envoy 1.28.x | |
There was a problem hiding this comment.
I've removed these as neither dataplane release spans multiple major Envoy versions, which is what this section of the doc is meant to be
nathancoleman
commented
Oct 17, 2024
Comment on lines
-141
to
-142
| | 1.2.0 - 1.2.latest | 1.18.x Ent | Envoy 1.27.x | | ||
| | 1.2.0 - 1.2.7 | 1.18.x Ent | Envoy 1.27.x | |
There was a problem hiding this comment.
I've removed these as they align with a now-unsupported version of Consul
zalimeni
approved these changes
Oct 17, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Envoy matrices to include latest set of releases for consul + consul-dataplane
Testing & Reproduction steps
Links
PR Checklist