-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Envoy compatibility matrices to include consul 1.20.x and dataplane 1.6.x #21852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personal review
@@ -122,7 +123,6 @@ until the LTS release reaches its end of maintenance. | |||
|
|||
| Consul Version | Default `consul-dataplane` Version | Other compatible `consul-dataplane` Versions | | |||
| -------------- | -------------------------------------|----------------------------------------------| | |||
| 1.19.x Ent | 1.5.x (Envoy 1.29.x) | 1.4.x (Envoy 1.28.x) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why 1.19 was included in this table of LTS releases, but I removed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍝
| 1.20.x CE | 1.6.x (Envoy 1.31.x) | 1.5.x (Envoy 1.29.x) | | ||
| 1.19.x CE | 1.5.x (Envoy 1.29.x) | 1.4.x (Envoy 1.28.x) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had to jump two versions at some point bc we'd started to lag >1 release on latest Envoy vs. latest Consul due to release cadence differences. 1.20 happened to be selected as the version for the jump.
…that span versions
| 1.5.0 - 1.5.latest | 1.18.x Ent | Envoy 1.29.x | | ||
| 1.4.0 - 1.4.latest | 1.18.x Ent | Envoy 1.28.x | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed these as neither dataplane release spans multiple major Envoy versions, which is what this section of the doc is meant to be
| 1.2.0 - 1.2.latest | 1.18.x Ent | Envoy 1.27.x | | ||
| 1.2.0 - 1.2.7 | 1.18.x Ent | Envoy 1.27.x | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed these as they align with a now-unsupported version of Consul
Description
Update Envoy matrices to include latest set of releases for consul + consul-dataplane
Testing & Reproduction steps
Links
PR Checklist