Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update the security-scanner gha token #21748

Merged
merged 1 commit into from
Sep 17, 2024
Merged

ci: update the security-scanner gha token #21748

merged 1 commit into from
Sep 17, 2024
+1 −1

Conversation

dduzgun-security
Copy link
Contributor

Description

Using the org level secret instead of the repository one.

Testing & Reproduction steps

If the security scan passes, we are good.

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@dduzgun-security dduzgun-security added type/ci Relating to continuous integration (CI) tooling for testing or releases pr/no-changelog PR does not need a corresponding .changelog entry backport/all Apply backports for all active releases per .release/versions.hcl labels Sep 17, 2024
@github-actions github-actions bot added the theme/contributing Additions and enhancements to community contributing materials label Sep 17, 2024
@dduzgun-security dduzgun-security merged commit 176ea31 into main Sep 17, 2024
123 checks passed
@dduzgun-security dduzgun-security deleted the ci/update-security-scanner-token branch September 17, 2024 14:49
@dduzgun-security dduzgun-security restored the ci/update-security-scanner-token branch September 17, 2024 14:50
@dduzgun-security dduzgun-security added backport/all Apply backports for all active releases per .release/versions.hcl and removed backport/all Apply backports for all active releases per .release/versions.hcl labels Sep 17, 2024
@dduzgun-security
Copy link
Contributor Author

@zalimeni & @sarahalsmiller does this require a manual backport? Couldn't see one being generated, maybe related to https://github.com/hashicorp/consul/actions/runs/10905529788/job/30264590705?

@zalimeni
Copy link
Member

zalimeni commented Sep 17, 2024 •
edited
Loading

@zalimeni & @sarahalsmiller does this require a manual backport? Couldn't see one being generated, maybe related to https://github.com/hashicorp/consul/actions/runs/10905529788/job/30264590705?

I think the comma added in https://github.com/hashicorp/consul/pull/21746/files#diff-a410ff1255fde1d45c73961d3a2de8e44698bdb4254a064a5aa3f6340d3f96e6R11 is causing strict HCL validation to fail in BPA, so affecting all backports. Opened a fix PR

@zalimeni zalimeni added backport/all Apply backports for all active releases per .release/versions.hcl and removed backport/all Apply backports for all active releases per .release/versions.hcl labels Sep 17, 2024
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.19 Changes are backported to 1.19 backport/1.20 Changes are backported to 1.20 backport/ent/1.17 Changes are backported to 1.17 ent backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent labels Sep 17, 2024
@zalimeni
Copy link
Member

Re-added label to kick off backport @dduzgun-security

This was referenced Sep 17, 2024
Merged
Merged
This was referenced Sep 25, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zalimeni zalimeni zalimeni approved these changes

@sarahalsmiller sarahalsmiller Awaiting requested review from sarahalsmiller

Assignees
No one assigned
Labels
backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.17 Changes are backported to 1.17 ent backport/ent/1.18 Changes are backported to 1.18 ent backport/1.19 Changes are backported to 1.19 backport/1.20 Changes are backported to 1.20 pr/no-changelog PR does not need a corresponding .changelog entry theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dduzgun-security @zalimeni @hc-github-team-consul-core