Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update pause Docker image in Envoy int tests #21659

Merged
merged 1 commit into from
Aug 26, 2024
Merged

test: update pause Docker image in Envoy int tests #21659

merged 1 commit into from
Aug 26, 2024

Conversation

zalimeni
Copy link
Member

k8s.gcr.io has been migrated to registry.k8s.io for several years now, and the old registry is being shut down, causing image pull failures.

Update to target the new registry when pulling the pause image used in Envoy integration tests.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@zalimeni zalimeni added pr/no-changelog PR does not need a corresponding .changelog entry backport/all Apply backports for all active releases per .release/versions.hcl labels Aug 26, 2024
@zalimeni
test: update pause Docker image in Envoy int tests
80d4929 
k8s.gcr.io has been migrated to registry.k8s.io for several years now,
and the old registry is being shut down, causing image pull failures.

Update to target the new registry when pulling the pause image used in
Envoy integration tests.
@zalimeni zalimeni force-pushed the zalimeni/fix-k8s-pause-image-envoy-tests branch from 6f7ff81 to 80d4929 Compare August 26, 2024 16:16
@zalimeni
Copy link
Member Author

Removed old comment about using HashiCorp mirror since this is not a Dockerhub image.

@zalimeni zalimeni enabled auto-merge (squash) August 26, 2024 16:19
@zalimeni zalimeni merged commit 2a99624 into main Aug 26, 2024
91 checks passed
@zalimeni zalimeni deleted the zalimeni/fix-k8s-pause-image-envoy-tests branch August 26, 2024 16:39
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.19 Changes are backported to 1.19 backport/ent/1.17 Changes are backported to 1.17 ent backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent labels Aug 26, 2024
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Aug 26, 2024
Merged
4 tasks
@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @zalimeni! a backport is missing for this PR [21659] for versions [1.15,1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

4 similar comments
@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @zalimeni! a backport is missing for this PR [21659] for versions [1.15,1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @zalimeni! a backport is missing for this PR [21659] for versions [1.15,1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @zalimeni! a backport is missing for this PR [21659] for versions [1.15,1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @zalimeni! a backport is missing for this PR [21659] for versions [1.15,1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

philrenaud pushed a commit that referenced this pull request Sep 12, 2024
@zalimeni @philrenaud
test: update pause Docker image in Envoy int tests (#21659)
d5960fe 
k8s.gcr.io has been migrated to registry.k8s.io for several years now,
and the old registry is being shut down, causing image pull failures.

Update to target the new registry when pulling the pause image used in
Envoy integration tests.
@dhiaayachi dhiaayachi mentioned this pull request Sep 25, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoletaPopoviciu NicoletaPopoviciu NicoletaPopoviciu approved these changes

Assignees
No one assigned
Labels
backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.17 Changes are backported to 1.17 ent backport/ent/1.18 Changes are backported to 1.18 ent backport/1.19 Changes are backported to 1.19 pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zalimeni @hc-github-team-consul-core @NicoletaPopoviciu