NET-10685 - Remove dns v2 code #21598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmurret
added
pr/no-changelog
github-actions
bot
added
type/docs
zalimeni
approved these changes
Aug 13, 2024
Comment on lines
-1102
to
+1112
| structs.IsErrSamenessGroupMustBeDefaultForFailover(err): | ||
| structs.IsErrSamenessGroupMustBeDefaultForFailover(err), | ||
| structs.IsErrSamenessGroupNotFound(err): |
There was a problem hiding this comment.
FYI, looks like this is a net-new changes based on comparing Ent, but it brings them into sync.
| func IsErrSamenessGroupNotFound(err error) bool { | ||
| return err != nil && strings.Contains(err.Error(), errSamenessGroupNotFound) | ||
| } | ||
|
|
There was a problem hiding this comment.
Same here: no concern having this in CE given this is not CE-exclusive code, but seems net-new. I'm guessing it was left out in past Ent work.
There was a problem hiding this comment.
yes. i had to fix this. it should have been in CE just like IsErrSamenessGroupMustBeDefaultForFailover
4 tasks
This was referenced Aug 14, 2024
philrenaud
pushed a commit
that referenced
this pull request
Sep 12, 2024
* NET-10685 - Remove dns v2 code * adding missing erro * add missing license info.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are not moving forward with this experimental code.
Testing & Reproduction steps
CI
Links
PR Checklist