Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NET-5688] APIGateway UI Topology Fixes (#19657) #19764

Merged
merged 3 commits into from
Nov 29, 2023
Merged

[NET-5688] APIGateway UI Topology Fixes (#19657) #19764

merged 3 commits into from
Nov 29, 2023

Conversation

jm96441n
Copy link
Member

@jm96441n jm96441n commented Nov 28, 2023 •
edited
Loading

Description

Manual backport of #19761

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern
Overview of commits

@jm96441n
[NET-5688] APIGateway UI Topology Fixes (#19657)
1214988 
* Update catalog and ui endpoints to show APIGateway in gateway service
topology view

* Added initial implementation for service view

* updated ui

* Fix topology view for gateways

* Adding tests for gw controller

* remove unused args

* Undo formatting changes

* Fix call sites for upstream/downstream gw changes

* Add config entry tests

* Fix function calls again

* Move from ServiceKey to ServiceName, cleanup from PR review

* Add additional check for length of services in bound apigateway for
IsSame comparison

* fix formatting for proto

* gofmt

* Add DeepCopy for retrieved BoundAPIGateway

* gofmt

* gofmt

* Rename function to be more consistent
@jm96441n jm96441n added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-docs PR does not include docs and should not trigger reminder for cherrypicking them. pr/no-backport labels Nov 28, 2023
@jm96441n jm96441n requested a review from a team as a code owner November 28, 2023 21:57
@github-actions github-actions bot added the theme/ui Anything related to the UI label Nov 28, 2023
@hc-github-team-consul-core
Copy link
Contributor

This PR has diffs in agent/uiserver/dist. If the changes are intentional, add the label pr/update-ui-assets. Otherwise, revert changes to agent/uiserver/dist.

3 similar comments
@hc-github-team-consul-core
Copy link
Contributor

This PR has diffs in agent/uiserver/dist. If the changes are intentional, add the label pr/update-ui-assets. Otherwise, revert changes to agent/uiserver/dist.

@hc-github-team-consul-core
Copy link
Contributor

This PR has diffs in agent/uiserver/dist. If the changes are intentional, add the label pr/update-ui-assets. Otherwise, revert changes to agent/uiserver/dist.

@hc-github-team-consul-core
Copy link
Contributor

This PR has diffs in agent/uiserver/dist. If the changes are intentional, add the label pr/update-ui-assets. Otherwise, revert changes to agent/uiserver/dist.

@jm96441n jm96441n added the pr/update-ui-assets This PR updates the embedded UI assets label Nov 28, 2023
@jm96441n jm96441n enabled auto-merge (squash) November 28, 2023 22:15
@jm96441n jm96441n merged commit 7cc019f into release/1.15.x Nov 29, 2023
83 checks passed
@jm96441n jm96441n deleted the backport/gwui-fixes-1.15 branch November 29, 2023 16:23
@jira jira bot mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-eckert t-eckert t-eckert approved these changes

Assignees
No one assigned
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry pr/no-docs PR does not include docs and should not trigger reminder for cherrypicking them. pr/update-ui-assets This PR updates the embedded UI assets theme/ui Anything related to the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jm96441n @hc-github-team-consul-core @t-eckert