Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.15.x] Vault CA bugfixes (#19285) #19337

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

kisunji
Copy link
Contributor

@kisunji kisunji commented Oct 23, 2023

  • Re-add retry logic to Vault token renewal

  • Fix goroutine leak

  • Add test for detecting goroutine leak

  • Add changelog

  • Rename tests

  • Add comment

Description

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@kisunji kisunji added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. labels Oct 23, 2023
@github-actions github-actions bot added the theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies label Oct 23, 2023
@kisunji kisunji requested a review from cthain October 23, 2023 14:00
@kisunji kisunji mentioned this pull request Oct 23, 2023
@kisunji kisunji enabled auto-merge (squash) October 23, 2023 14:01
* Re-add retry logic to Vault token renewal

* Fix goroutine leak

* Add test for detecting goroutine leak

* Add changelog

* Rename tests

* Add comment
Copy link
Contributor

@cthain cthain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against #19285 👍

@kisunji kisunji merged commit bb4ea08 into release/1.15.x Oct 23, 2023
83 checks passed
@kisunji kisunji deleted the kisunji/1.15.x-backport branch October 23, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. pr/no-changelog PR does not need a corresponding .changelog entry theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants