Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of mesh: provide missing domain to route configurations in ProxyStateTemplate into release/1.17.0 #19305

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Backport of mesh: provide missing domain to route configurations in ProxyStateTemplate into release/1.17.0 #19305

merged 1 commit into from
Oct 20, 2023

Conversation

zalimeni
Copy link
Member

Backport

This PR is manually generated from #19298 for backporting to the 1.17.0 GA release branch.

The below text is copied from the body of the original PR.

Description

  • domain was missing, I think it's ok to just hardcode ["*"] for now

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@hc-github-team-consul-core @ndhanushkodi @zalimeni
Backport of mesh: provide missing domain to route configurations in P…
9098b3e 
…roxyStateTemplate into release/1.17.0

* backport of commit 21c8b5e

* backport of commit 925d695

---------

Co-authored-by: Nitya Dhanushkodi <nitya@hashicorp.com>
@zalimeni zalimeni added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Oct 20, 2023
NicoletaPopoviciu
NicoletaPopoviciu approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@NicoletaPopoviciu NicoletaPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm compared w original Pr #19298

@zalimeni zalimeni merged commit 6a39ad2 into release/1.17.0 Oct 20, 2023
94 of 95 checks passed
@zalimeni zalimeni deleted the backport/nd/mz/l7-fixes/1.17.0-manual branch October 20, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoletaPopoviciu NicoletaPopoviciu NicoletaPopoviciu approved these changes

Assignees
No one assigned
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zalimeni @NicoletaPopoviciu @hc-github-team-consul-core