Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Net 4893- Ensure we're testing all the latest versions of Vault/Nomad into release/1.17.x #19251

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Backport of Net 4893- Ensure we're testing all the latest versions of Vault/Nomad into release/1.17.x #19251

merged 2 commits into from
Oct 17, 2023

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #19119 to be assessed for backporting due to the inclusion of the label backport/1.17.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@sophie-gairo
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: unable to process merge commit: "b5c01b5137ca9939c2fdc2dce2018440b36d9fc2", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.

Description

Test Nomad's latest supported releases : v1.6.2, v1.5.9, v1.4.13

Test Vault's latest supported releases : "1.15.0", "1.14.4", "1.13.8", "1.12.11"

Testing & Reproduction steps

Links

PR Checklist

  • [x ] updated test coverage
  • external facing docs updated
  • [ x] appropriate backport labels added
  • [ x] not a security concern
Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/NET-4893/routinely-immune-spider branch from ceb320e to 5e1714e Compare October 17, 2023 17:55
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/NET-4893/routinely-immune-spider branch from 38fbdbf to 626ee82 Compare October 17, 2023 17:55
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Oct 17, 2023
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Oct 17, 2023
@DanStough DanStough marked this pull request as ready for review October 17, 2023 18:01
@vercel vercel bot temporarily deployed to Preview – consul October 17, 2023 18:02 Inactive
@DanStough DanStough enabled auto-merge (squash) October 17, 2023 18:02
@DanStough DanStough merged commit aa94206 into release/1.17.x Oct 17, 2023
88 of 89 checks passed
@DanStough DanStough deleted the backport/NET-4893/routinely-immune-spider branch October 17, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

@sophie-gairo sophie-gairo Awaiting requested review from sophie-gairo

Assignees

@sophie-gairo sophie-gairo

Labels
theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hc-github-team-consul-core @github-team-consul-core-pr-approver @DanStough @sophie-gairo