Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.15.x] Update upgrade-specific.mdx #19063

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

kisunji
Copy link
Contributor

@kisunji kisunji commented Oct 4, 2023

Description

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@kisunji kisunji requested a review from a team as a code owner October 4, 2023 20:13
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Oct 4, 2023
@hc-github-team-consul-core
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

Copy link
Contributor

@jkirschner-hashicorp jkirschner-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -134,7 +144,7 @@ In Consul v1.15 and higher:
UpstreamConfig = {
Overrides = [
{
Name = foo # Applies to local service `foo`
Name = foo # Applies to local service `foo`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone is using a linter ;)

@kisunji kisunji merged commit 5dd7d91 into release/1.15.x Oct 4, 2023
58 of 59 checks passed
@kisunji kisunji deleted the kisunji-patch-2 branch October 4, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants