Fix some docs/internals typos and add raft link #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jpfuentes2
commented
Apr 3, 2014
jpfuentes2
commented
- Add some row highlighting to the suggested quorum numbers.
|
Thanks! |
armon
added a commit
that referenced
this pull request
Apr 3, 2014
Fix some docs/internals typos and add raft link
KrolikROJER
pushed a commit
to KrolikROJER/consul
that referenced
this pull request
Nov 23, 2018
Update Newtonsoft.Json to version 7.0.1
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
Define sync channels without creating and closing them
absolutelightning
pushed a commit
that referenced
this pull request
Jun 21, 2023
hashi-derek
added a commit
that referenced
this pull request
Oct 24, 2023
#19347) Backport of Add grpc keepalive configuration into release/1.15.x (#19339) Add grpc keepalive configuration. (#19339) Prior to the introduction of this configuration, grpc keepalive messages were sent after 2 hours of inactivity on the stream. This posed issues in various scenarios where the server-side xds connection balancing was unaware that envoy instances were uncleanly killed / force-closed, since the connections would only be cleaned up after ~5 minutes of TCP timeouts occurred. Setting this config to a 30 second interval with a 20 second timeout ensures that at most, it should take up to 50 seconds for a dead xds connection to be closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.