Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of docs: Fix ServiceDefaults example in distributed tracing into release/1.16.x #18973

Conversation

blake
Copy link
Member

@blake blake commented Sep 21, 2023

Description

backport of commmit 38c356c

@blake blake added type/docs Documentation needs to be created/updated/clarified pr/no-changelog PR does not need a corresponding .changelog entry labels Sep 21, 2023
@blake blake self-assigned this Sep 21, 2023
@blake blake requested a review from a team as a code owner September 21, 2023 23:47
@blake blake force-pushed the backports/docs/fix-servicedefaults-distributed-tracing-1.16.x branch from b210e56 to 110f63f Compare September 21, 2023 23:50
@blake blake enabled auto-merge (squash) September 21, 2023 23:52
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Approving on behalf of consul-docs

@blake blake merged commit ddc6f15 into release/1.16.x Sep 22, 2023
47 of 48 checks passed
@blake blake deleted the backports/docs/fix-servicedefaults-distributed-tracing-1.16.x branch September 22, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants