Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of docs: Fix invalid JSON into release/1.16.x #18960

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Backport of docs: Fix invalid JSON into release/1.16.x #18960

merged 1 commit into from
Sep 21, 2023

Conversation

blake
Copy link
Member

@blake blake commented Sep 21, 2023

Description

backport of commit cc40e08

@blake blake added type/docs Documentation needs to be created/updated/clarified pr/no-changelog PR does not need a corresponding .changelog entry labels Sep 21, 2023
@blake blake requested a review from a team as a code owner September 21, 2023 20:45
@blake blake self-assigned this Sep 21, 2023
@blake blake changed the title Backport of Fix invalid JSON into release/1.16.x Manual backport of Fix invalid JSON into release/1.16.x Sep 21, 2023
@github-actions github-actions bot added the theme/consul-terraform-sync Relating to Consul Terraform Sync and Network Infrastructure Automation label Sep 21, 2023
@blake blake changed the title Manual backport of Fix invalid JSON into release/1.16.x Backport of docs: Fix invalid JSON into release/1.16.x Sep 21, 2023
@blake blake enabled auto-merge (squash) September 21, 2023 21:35
boruszak
boruszak approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Approving on behalf of consul-docs.

@blake blake force-pushed the backport/docs/fix-invalid-json-config-api-examples/consul-1.16.x branch from e3bac9e to afe05ca Compare September 21, 2023 22:15
@blake blake merged commit 54be594 into release/1.16.x Sep 21, 2023
47 of 48 checks passed
@blake blake deleted the backport/docs/fix-invalid-json-config-api-examples/consul-1.16.x branch September 21, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boruszak boruszak boruszak approved these changes

Assignees

@blake blake

Labels
pr/no-changelog PR does not need a corresponding .changelog entry theme/consul-terraform-sync Relating to Consul Terraform Sync and Network Infrastructure Automation type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blake @boruszak