Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of when skip-ci is true do not trigger integration and go tests into release/1.15.x #18955

Merged

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #18948 to be assessed for backporting due to the inclusion of the label backport/1.15.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@NiniOak
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: unable to process merge commit: "a75f68f45012342e941f5b1a8941ce67074f0e60", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Description

PROBLEM
Actions was not correctly reading the result of script to not run CI, it continuously ran CI when changes were only to docs file. See example here

SOLUTION
Push the result of script to GITHUB_OUTPUT which can be read easily by Github Actions to execute workflows conditionally.

Testing & Reproduction steps

CI runs all workflows where non doc files are included in changeset
CI skips test workflows when only doc files are in changeset

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/test_skip_ci/overly-profound-falcon branch 2 times, most recently from d59f575 to 7c73e45 Compare September 21, 2023 19:52
@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Sep 21, 2023
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@NiniOak NiniOak marked this pull request as ready for review September 21, 2023 19:56
@NiniOak NiniOak enabled auto-merge (squash) September 21, 2023 19:57
@NiniOak NiniOak merged commit 40a98f4 into release/1.15.x Sep 21, 2023
169 checks passed
@NiniOak NiniOak deleted the backport/test_skip_ci/overly-profound-falcon branch September 21, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants