Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post-release updates for 1.15.x #17559

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Post-release updates for 1.15.x #17559

merged 1 commit into from
Jun 15, 2023

Conversation

malizz
Copy link
Contributor

@malizz malizz commented Jun 2, 2023 •
edited
Loading

Description

Post-release updates for 1.15.x

  • update version
  • add changelog 1.15.3
  • update go modules

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@malizz malizz requested review from zalimeni and DanStough June 2, 2023 16:23
@github-actions github-actions bot added pr/dependencies PR specifically updates dependencies of project theme/api Relating to the HTTP API interface labels Jun 2, 2023
zalimeni
zalimeni reviewed Jun 2, 2023
View reviewed changes
Copy link
Member

@zalimeni zalimeni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, one question in diff.

We might also want to change the PR title to reflect all the changes here, e.g. "Post-release updates for 1.15.x"

go.mod Outdated
Comment on lines 5 to 11
replace (
github.com/hashicorp/consul/api => ./api
github.com/hashicorp/consul/envoyextensions => ./envoyextensions
github.com/hashicorp/consul/proto-public => ./proto-public
github.com/hashicorp/consul/sdk => ./sdk
github.com/hashicorp/consul/troubleshoot => ./troubleshoot
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this removal intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can comment it out instead, I believe go mod tidy removed these lines. Thanks.

@malizz malizz changed the title update version changelog 1.15.3 Post-release updates for 1.15.x Jun 2, 2023
@malizz malizz requested a review from zalimeni June 2, 2023 19:40
@zalimeni zalimeni force-pushed the malizz/update-version-changelog-1.15.3 branch from cdc24b8 to de5bf5c Compare June 8, 2023 14:38
@zalimeni
Copy link
Member

zalimeni commented Jun 8, 2023

Squashed commits and removed replace comments for the running release branch.

@zalimeni zalimeni enabled auto-merge (squash) June 8, 2023 14:38
@zalimeni zalimeni removed the theme/api Relating to the HTTP API interface label Jun 8, 2023
@zalimeni zalimeni force-pushed the malizz/update-version-changelog-1.15.3 branch from de5bf5c to d69959d Compare June 14, 2023 15:13
@zalimeni
Copy link
Member

Added required test/integration/consul-container/go.mod update to fix linter failures

@zalimeni zalimeni merged commit 09e11fb into release/1.15.x Jun 15, 2023
@zalimeni zalimeni deleted the malizz/update-version-changelog-1.15.3 branch June 15, 2023 13:17
@jjti jjti mentioned this pull request Aug 28, 2023
Closed
@jira jira bot mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zalimeni zalimeni zalimeni approved these changes

@DanStough DanStough Awaiting requested review from DanStough

Assignees
No one assigned
Labels
pr/dependencies PR specifically updates dependencies of project pr/no-backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malizz @zalimeni