prototest: fix early return condition in AssertElementsMatch #17416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rboyer
added
pr/no-changelog
rboyer
commented
May 19, 2023
| @@ -63,8 +70,8 @@ func AssertElementsMatch[V any]( | |||
| } | |||
| } | |||
|
|
|||
| if len(outX) == len(outY) && len(listX) == len(listY) { | |||
| return // matches | |||
| if len(outX) == len(listX) && len(outY) == len(listY) { | |||
hashi-derek
approved these changes
May 19, 2023
|
Prefer the improved test in this commit 9fbced6 where |
mkeeler
approved these changes
May 19, 2023
…he backend so Version stays in sync
rboyer
added a commit
that referenced
this pull request
May 19, 2023
manual backport of #17416 to 1.15.x
rboyer
added a commit
that referenced
this pull request
May 19, 2023
manual backport of #17416 to 1.15.x
rboyer
added a commit
that referenced
this pull request
May 19, 2023
manual backport of #17416 to 1.13.x
rboyer
added a commit
that referenced
this pull request
May 19, 2023
manual backport of #17416 to 1.14.x
rboyer
added
pr/no-backport
and removed
backport/1.13
backport/1.15
|
Since the failed tests were all in features recently changed, the backports were all done manually to elide the irrelevant changes. |
nickethier
pushed a commit
that referenced
this pull request
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prototest.AssertElementsMatchhas an early return condition that returned early incorrectly when two slices were actually different.