Backport of upgrade test: use docker.mirror.hashicorp.services to avoid docker login into release/1.15.x #17242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/upgrade-test-use-mirror-hashicorp/suitably-communal-pelican
branch
from
7cb0fd4
to
374d63e
Compare
hc-github-team-consul-core
force-pushed
the
backport/upgrade-test-use-mirror-hashicorp/suitably-communal-pelican
branch
from
df4e76d
to
ca6eaf3
Compare
github-team-consul-core-pr-approver
approved these changes
May 8, 2023
github-actions
bot
added
theme/contributing
huikang
force-pushed
the
backport/upgrade-test-use-mirror-hashicorp/suitably-communal-pelican
branch
from
ca6eaf3
to
7a06dfc
Compare
huikang
approved these changes
May 8, 2023
hc-github-team-consul-core
deleted the
backport/upgrade-test-use-mirror-hashicorp/suitably-communal-pelican
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17186 to be assessed for backporting due to the inclusion of the label backport/1.15.
The below text is copied from the body of the original PR.
Description
Use docker image from
docker.mirror.hashicorp.servicesto avoid docker login in GHAAlso add image name as parameter to
cluster.StandardUpgrade(utils.GetTargetImageName(), tc.targetVersion), because the image we upgrade to isconsul:locally, which is different than the latest imagedocker.mirror.hashicorp.services/docker:1.15for example.PR Checklist
Overview of commits