Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post a PR comment if the backport runner fails #17197

Merged
merged 1 commit into from
May 9, 2023

Conversation

freddygv
Copy link
Contributor

Description

Based on:

Currently when the backport runner fails it fails silently. This commit adds a step to comment on the PR so that the author can know it failed.

Opted not to post to a Slack channel because not everyone is in the GH/CI feed channels, and it could be too noisy for #team-consul.

I'm not sure about how to test that this works, open to suggestions!

@freddygv freddygv requested review from a team and wangxinyi7 and removed request for a team April 29, 2023 00:24
@github-actions github-actions bot added theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases labels Apr 29, 2023
@freddygv freddygv added pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry labels Apr 29, 2023
Copy link
Contributor

@DanStough DanStough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I wouldn't be opposed to backporting this to the release branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. pr/no-changelog PR does not need a corresponding .changelog entry theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants