ci: adding in fix for success jobs getting skipped. #17132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmurret
added
pr/no-changelog
github-actions
bot
added
theme/contributing
loshz
suggested changes
Apr 25, 2023
loshz
approved these changes
Apr 25, 2023
analogue
added a commit
that referenced
this pull request
Apr 25, 2023
…st day or so (#17130) * Fix straggler from renaming Register->RegisterTypes * somehow a lint failure got through previously * Fix lint-consul-retry errors * adding in fix for success jobs getting skipped. (#17132) * Temporarily disable inmem backend conformance test to get green pipeline * Another test needs disabling --------- Co-authored-by: John Murret <john.murret@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current
successjobs are sometimes being skipped when there are failures in dependent jobs. In these cases, the branch protection rules that use the required checks are treating this as a non-failure and allowing PRs to be merged even though there are failures. an example is here: https://github.com/hashicorp/consul/actions/runs/4797440861Testing & Reproduction steps
Links
PR Checklist