-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix test splits that have less test packages than runner count from hanging #17080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rix size is smaller than total_runners, use the smaller number
jmurret
added
pr/no-changelog
PR does not need a corresponding .changelog entry
backport/1.13
backport/1.15
This release series is no longer active on CE. Use backport/ent/1.15.
labels
Apr 20, 2023
github-actions
bot
added
theme/contributing
Additions and enhancements to community contributing materials
type/ci
Relating to continuous integration (CI) tooling for testing or releases
labels
Apr 20, 2023
loshz
reviewed
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one comment about the push
trigger. The rest are non-blocking syntactic bash NITs.
Co-authored-by: Dan Bond <danbond@protonmail.com>
loshz
approved these changes
Apr 21, 2023
This was referenced Apr 21, 2023
lonecalvary78
pushed a commit
to lonecalvary78/consul
that referenced
this pull request
Apr 22, 2023
…om hanging (hashicorp#17080) * use proper TOTAL_RUNNER setting when generating runner matrix. if matrix size is smaller than total_runners, use the smaller number * try again * try again 2 * try again 3 * try again 4 * try again 5 * try scenario where number is less * reset * get rid of cat "$GITHUB_OUTPUT" * Apply suggestions from code review Co-authored-by: Dan Bond <danbond@protonmail.com> * removing push trigger that was added for debug --------- Co-authored-by: Dan Bond <danbond@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/1.15
This release series is no longer active on CE. Use backport/ent/1.15.
pr/no-changelog
PR does not need a corresponding .changelog entry
theme/contributing
Additions and enhancements to community contributing materials
type/ci
Relating to continuous integration (CI) tooling for testing or releases
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In 1.13, there are only two compatibility test packages. So when a generate matrix job has a TOTAL_RUNNERS of 5 but there are only 2 packages, the process hangs. This PR changes the runner count to 2 in this case.
Another issue that occurs that is fixed in this PR is that when you specify TOTAL_RUNNERS = 4, you will actually split across 5 runners. (The same occurs with any number you set TOTAL_RUNNERS to. You will actually get 1 greater.)