Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of feat: add reporting config with reload #16977

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Backport of feat: add reporting config with reload #16977

merged 1 commit into from
Apr 13, 2023

Conversation

JadhavPoonam
Copy link
Contributor

Description

Manually backporting: #16890

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@github-actions github-actions bot added the theme/config Relating to Consul Agent configuration, including reloading label Apr 12, 2023
@JadhavPoonam JadhavPoonam added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Apr 12, 2023
@JadhavPoonam JadhavPoonam marked this pull request as ready for review April 12, 2023 15:45
@JadhavPoonam JadhavPoonam changed the title feat: add reporting config with reload Backport of feat: add reporting config with reload Apr 12, 2023
dhiaayachi
dhiaayachi approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@dhiaayachi dhiaayachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JadhavPoonam JadhavPoonam merged commit fc1ba0f into release/1.15.x Apr 13, 2023
@JadhavPoonam JadhavPoonam deleted the backport/NET-3476/add-reporting-config/release-1.15.x branch April 13, 2023 15:42
@jjti jjti mentioned this pull request Aug 28, 2023
Closed
@dlaguerta dlaguerta mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhiaayachi dhiaayachi dhiaayachi approved these changes

Assignees
No one assigned
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry theme/config Relating to Consul Agent configuration, including reloading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JadhavPoonam @dhiaayachi