Backport of Update normalization of route refs into release/1.15.x #16799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/jm96441n/update-normalization-of-route-refs/certainly-sweet-chimp
branch
from
67e325b
to
cad9250
Compare
hc-github-team-consul-core
force-pushed
the
backport/jm96441n/update-normalization-of-route-refs/certainly-sweet-chimp
branch
from
a08041d
to
49898b3
Compare
github-team-consul-core-pr-approver
approved these changes
Mar 28, 2023
jm96441n
approved these changes
Mar 28, 2023
jm96441n
deleted the
backport/jm96441n/update-normalization-of-route-refs/certainly-sweet-chimp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16789 to be assessed for backporting due to the inclusion of the label backport/1.15.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Description
When normalizing refs to routes, if the ref does not specify a namespace we should default to the routes namespace. Previously this would always default back to the default namespace.
Testing & Reproduction steps
In consul enterprise create an api gateway and a service in a namespace, then create a route in the same namespace from the gateway to the service and in the stanzas for the gw and the service do not specify the namespace. Before this change the route will fail to bind because it assumes the gw and service are in the default ns, after this change it will bind correctly.
Links
N/A
PR Checklist
Overview of commits