Backport of Fix route subscription when using namespaces into release/1.15.x #16680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/fix-bug-with-cross-namespace-routes/actually-ample-jennet
branch
from
ce678d5
to
e580deb
Compare
hc-github-team-consul-core
force-pushed
the
backport/fix-bug-with-cross-namespace-routes/actually-ample-jennet
branch
2 times, most recently
from
c00b69b
to
2518f54
Compare
github-team-consul-core-pr-approver
approved these changes
Mar 20, 2023
…ace-routes/actually-ample-jennet
…ace-routes/actually-ample-jennet
…ace-routes/actually-ample-jennet
jm96441n
deleted the
backport/fix-bug-with-cross-namespace-routes/actually-ample-jennet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16677 to be assessed for backporting due to the inclusion of the label backport/1.15.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Description
We’re improperly subscribing to our routes in the proxycfg package, leveraging the proxy enterprise metadata rather than the route metadata. This causes the gateway to never get configured when it binds a route in another namespace. This PR fixes that by ensuring the correct EnterpriseMeta is used to reference the namespace
Testing & Reproduction steps
In consul enterprise set up a two namespaces, a gateway in one namespace, a service in the other, and attempt to setup a httproute in the service namespace. The route will never register without this fix (also automated tests showing this are coming up in a follow up PR).
Links
N/A
PR Checklist
Overview of commits