Backport of Fix issue with trust bundle read ACL check. into release/1.15.x #16635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/derekm/NET-3226/trust-bundle-read-acl/neatly-resolved-elf
branch
from
04d882f
to
77e004f
Compare
hc-github-team-consul-core
force-pushed
the
backport/derekm/NET-3226/trust-bundle-read-acl/neatly-resolved-elf
branch
from
c42c342
to
fc1fbb3
Compare
github-team-consul-core-pr-approver
approved these changes
Mar 14, 2023
hc-github-team-consul-core
deleted the
backport/derekm/NET-3226/trust-bundle-read-acl/neatly-resolved-elf
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16630 to be assessed for backporting due to the inclusion of the label backport/1.15.
The below text is copied from the body of the original PR.
This commit fixes an issue where trust bundles could not be read by services in a non-default namespace, unless they had excessive ACL permissions given to them.
Prior to this change,
service:writewas required in the default namespace in order to read the trust bundle. Now,service:writeto a service in any namespace is sufficient.Overview of commits