Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #16274 #16491

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Backport #16274 #16491

merged 1 commit into from
Mar 1, 2023

Conversation

nathancoleman
Copy link
Member

@nathancoleman nathancoleman commented Mar 1, 2023

Description

#16274 updated the Envoy compatibility list but wasn't backported into the release/1.15.x branch prior to cutting the Consul 1.15.0 release from that branch. This is causing Consul 1.15.0 to report invalid Envoy version for newer Envoy releases - 1.25.1, for example - that are valid according to the compatibility chart in our docs.

This backport makes it so that our next patch release will accept the newer version of Envoy without warning the user.

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

…to 1.24.2, add 1.25.1, remove 1.21.5 (#16274)

* Bump Envoy 1.22.5 to 1.22.7, 1.23.2 to 1.23.4, 1.24.0 to 1.24.2, add 1.25.1, remove 1.21.5
@nathancoleman nathancoleman added type/docs Documentation needs to be created/updated/clarified type/ci Relating to continuous integration (CI) tooling for testing or releases labels Mar 1, 2023
@nathancoleman nathancoleman requested a review from a team as a code owner March 1, 2023 20:25
@nathancoleman nathancoleman added the pr/no-changelog PR does not need a corresponding .changelog entry label Mar 1, 2023
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah! I backported on ENT but not OSS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/ci Relating to continuous integration (CI) tooling for testing or releases type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consul reporting valid Envoy versions as "not supported"
3 participants