Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Docs/reformat service splitters conf entry into release/1.15.x #16283

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #16264 to be assessed for backporting due to the inclusion of the label type/docs-cherrypick.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: unable to process merge commit: "54fa0170cf059e05e46bee9c9dd0e7c276aa26cf", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Description

This PR reformats the service splitter configuration entries reference documentation to the standard defined in our content types guidelines. The changes are mostly about formatting how the information is presented, so the text is the same or similar for most fields. We edited some of the content for clarity, though, which should be verified before merging.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

Overview of commits

trujillo-adam and others added 2 commits February 15, 2023 15:21
* for tab testing

* updates

* Update

* adding sandbox to test conf ref types

* testing tweaks to the conf ref template

* reintroduce tabbed specification

* applied feedback from MKO session

* applied feedback on format from luke and jared

* Apply suggestions from code review

Co-authored-by: Dan Upton <daniel@floppy.co>

* fixed some minor HCL formatting in complete conf

* Apply suggestions from code review

Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>

* fixed bad link

* resolving conflicts

---------

Co-authored-by: boruszak <jeffrey.boruszak@hashicorp.com>
Co-authored-by: Dan Upton <daniel@floppy.co>
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>

resolved cherry-pick conflicts
@trujillo-adam trujillo-adam merged commit de2bcab into release/1.15.x Feb 21, 2023
@trujillo-adam trujillo-adam deleted the backport/docs/reformat-service-splitters-conf-entry/painfully-credible-mako branch February 21, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants