Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peering: default to false #13963

Merged
merged 8 commits into from
Aug 1, 2022
Merged

peering: default to false #13963

merged 8 commits into from
Aug 1, 2022

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Jul 29, 2022

Because peering will be released as beta default it to false

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

@lkysow lkysow added pr/no-changelog PR does not need a corresponding .changelog entry theme/cluster-peering Related to Consul's cluster peering feature backport/1.13 labels Jul 29, 2022
@github-actions github-actions bot added the theme/config Relating to Consul Agent configuration, including reloading label Jul 29, 2022
@lkysow lkysow force-pushed the lkysow/peering-default-false branch from a4dc984 to 6120d26 Compare July 29, 2022 20:22
Because peering will be released as beta
@lkysow lkysow force-pushed the lkysow/peering-default-false branch from 1759481 to a3a232a Compare July 29, 2022 21:03
@lkysow lkysow marked this pull request as ready for review July 29, 2022 21:06
@lkysow lkysow requested a review from a team as a code owner July 29, 2022 21:06
Copy link
Contributor

@acpana acpana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we accidentally raced 🙈 w #13887

otherwise, changes LGTM!

Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkeeler mkeeler force-pushed the lkysow/peering-default-false branch from 96d2e5b to a02fedc Compare August 1, 2022 15:30
@mkeeler
Copy link
Member

mkeeler commented Aug 1, 2022

All the integration tests failing look like legit failures.

For some reason things only fail when in client mode.

@mkeeler

This comment was marked as outdated.

mkeeler added a commit that referenced this pull request Aug 1, 2022
* defaulting to false because peering will be released as beta
* Ignore peering disabled error in bundles cachetype

Co-authored-by: Matt Keeler <mkeeler@users.noreply.github.com>
Co-authored-by: freddygv <freddy@hashicorp.com>
Co-authored-by: Matt Keeler <mjkeeler7@gmail.com>
mkeeler added a commit that referenced this pull request Aug 1, 2022
* defaulting to false because peering will be released as beta
* Ignore peering disabled error in bundles cachetype

Co-authored-by: Matt Keeler <mkeeler@users.noreply.github.com>
Co-authored-by: freddygv <freddy@hashicorp.com>
Co-authored-by: Matt Keeler <mjkeeler7@gmail.com>
mkeeler added a commit that referenced this pull request Aug 1, 2022
* defaulting to false because peering will be released as beta
* Ignore peering disabled error in bundles cachetype

Co-authored-by: Matt Keeler <mkeeler@users.noreply.github.com>
Co-authored-by: freddygv <freddy@hashicorp.com>
Co-authored-by: Matt Keeler <mjkeeler7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry theme/cluster-peering Related to Consul's cluster peering feature theme/config Relating to Consul Agent configuration, including reloading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants