Skip to content

Commit

Permalink
Remove invalid 1xx HTTP codes
Browse files Browse the repository at this point in the history
These tests started failing in go1.19, presumably due to
support for valid 1xx responses being added.

golang/go#56346
  • Loading branch information
Chris S. Kim authored and kisunji committed Oct 24, 2022
1 parent bde57c0 commit 9f0ed81
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions agent/checks/check_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,17 @@ import (
"testing"
"time"

"github.com/hashicorp/go-uuid"
"github.com/stretchr/testify/require"
"golang.org/x/net/http2"
"golang.org/x/net/http2/h2c"

"github.com/hashicorp/consul/agent/mock"
"github.com/hashicorp/consul/agent/structs"
"github.com/hashicorp/consul/api"
"github.com/hashicorp/consul/sdk/freeport"
"github.com/hashicorp/consul/sdk/testutil"
"github.com/hashicorp/consul/sdk/testutil/retry"
"github.com/hashicorp/go-uuid"
"github.com/stretchr/testify/require"
http2 "golang.org/x/net/http2"
"golang.org/x/net/http2/h2c"
)

func uniqueID() string {
Expand Down Expand Up @@ -300,8 +301,6 @@ func TestCheckHTTP(t *testing.T) {
{code: 429, status: api.HealthWarning},

// critical
{code: 150, status: api.HealthCritical},
{code: 199, status: api.HealthCritical},
{code: 300, status: api.HealthCritical},
{code: 400, status: api.HealthCritical},
{code: 500, status: api.HealthCritical},
Expand Down

0 comments on commit 9f0ed81

Please sign in to comment.