Fixes Secondary ConnectCA update

This fixes a bug that was identified which resulted in subsequent ConnectCA configuration update not to persist in the cluster.
hashicorp · Jun 23, 2023 · 1b04465 · 1b04465
1 parent b782f2e
commit 1b04465
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/agent/consul/leader_connect_ca.go b/agent/consul/leader_connect_ca.go
@@ -735,7 +735,9 @@ func shouldPersistNewRootAndConfig(newActiveRoot *structs.CARoot, oldConfig, new
 	if newConfig == nil {
 		return false
 	}
-	return newConfig.Provider == oldConfig.Provider && reflect.DeepEqual(newConfig.Config, oldConfig.Config)
+
+	// Need not persist when the provider, old and new config is the same
+	return !(newConfig.Provider == oldConfig.Provider && reflect.DeepEqual(newConfig.Config, oldConfig.Config))
 }
 
 func (c *CAManager) UpdateConfiguration(args *structs.CARequest) (reterr error) {