Hack week: integrate with HCP Vault Secrets aka HVS #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om HVS. Currently oriented around HVS in a PRDE, since that's convenient for testing. As such, hacked the tests to put test instances of Nomad and Vault on 127.0.0.2 instead of 127.0.0.1, as they would otherwise collide with PRDE proxy. To run the tests it's therefore necessary to run `sudo ifconfig lo0 alias 127.0.0.2` on MacOS or `sudo route add -host 127.0.0.2 dev lo` on Linux. The following env vars also need to be set: * HCP_API_TLS=disabled * HCP_API_ADDRESS=localhost:28081 * PRDE_SERVICE_NAME=ncabatoff01-9yir6h5q (use the part between "registry" and ".dev.pedp" in the "docker registry" output line of hcloud hcp dev proxy) * HCP_CLIENT_SECRET * HCP_CLIENT_ID * HCP_PROJECT_ID * HCP_ORGANIZATION_ID
…template -once -dry -template "in.tpl:out.txt"`, where in.tpl looks like:
```
{{ range hvsSecrets "sample-app" }}
{{ hvsSecret (printf "sample-app/%s" .) }}
{{ end }}
```
ncabatoff
added a commit
to hashicorp/nomad
that referenced
this pull request
May 30, 2024
ncabatoff
commented
Jun 3, 2024
| @@ -305,7 +305,7 @@ func (v *View) fetch(doneCh, successCh chan<- struct{}, errCh chan<- error) { | |||
| } | |||
| } | |||
|
|
|||
| const minDelayBetweenUpdates = time.Millisecond * 100 | |||
| const minDelayBetweenUpdates = time.Millisecond * 1000 | |||
There was a problem hiding this comment.
This is still not really sufficient. With this change, each HVS secret appearing in a template now only gets polled once per second. But it wouldn't take very many templated secrets to start hitting API rate limits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently oriented around HVS in a PRDE, since that's convenient for testing. As such, hacked the tests to put test instances of Nomad and Vault on 127.0.0.2 instead of 127.0.0.1, as they would otherwise collide with PRDE proxy. To run the tests it's therefore necessary to run
sudo ifconfig lo0 alias 127.0.0.2on MacOS orsudo route add -host 127.0.0.2 dev loon Linux.The following env vars also need to be set:
You can test the new funcs using
make dev && consul-template -once -dry -template "in.tpl:out.txt", where in.tpl looks like:The output (assuming you created the sample-app using the gui) should be: