Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also pass down max conns per host to consul and nomad http transports #1933

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

n-marton
Copy link
Contributor

following up #1858 and #1840 this change also makes use of the max_conns_per_host param for nomad and consul clients to make it consistent and to prevent dosing there

cc @ccapurso

@eduardolmedeiros
Copy link

hey @ccapurso, any chance to have a look on that?

Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix!

@ncode
Copy link

ncode commented Jun 10, 2024

@ccapurso this consul-enterprise test doesn't look to be related to the patch

@n-marton
Copy link
Contributor Author

@ccapurso is there anything else needed to merge this?

@n-marton
Copy link
Contributor Author

can this be merged anytime soon?

@ccapurso ccapurso merged commit 0882681 into hashicorp:main Sep 24, 2024
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants