Revert go.mod changes in CLI from PR #835 #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndhanushkodi
changed the title
ndhanushkodi
changed the title
ndhanushkodi
commented
Dec 5, 2021
.circleci/config.yml
Outdated
| - acceptance-aks-1-20: | ||
| requires: | ||
| - cleanup-azure-resources | ||
| - acceptance-kind-1-22 | ||
| nightly-acceptance-tests: |
There was a problem hiding this comment.
This file will be reverted before merging
ndhanushkodi
requested review from
a team,
kschoche and
t-eckert
and removed request for
a team
kschoche
approved these changes
Dec 5, 2021
t-eckert
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert go.mod changes from 835
The cloud acceptance tests for the CLI have been failing (but passing in Kind) since merging 835. After reverting the whole PR and testing with several parts of that PR, it looks like the code itself wasn't causing issues, but rather the extensive go.mod updates. Those updates were not necessary for the PR (I was able to run go mod tidy with no changes), so I'm reverting those here so the tests will pass again.
How I've tested this PR:
Ran all cloud acceptance tests on this branch.
How I expect reviewers to test this PR:
👀