Give better error when using default service acct #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
requested review from
a team,
ishustava and
t-eckert
and removed request for
a team
lkysow
force-pushed
the
lkysow/service-account-err
branch
from
2d06441
to
0b76bf0
Compare
ishustava
approved these changes
Nov 5, 2021
If consul login fails when the service account name is `default` then give an explicit warning that the reason it failed is because in default installations that is not a support service account name. We can't fail during injection because we support modifying the binding rule such that `default` _is_ a valid svc account name.
lkysow
force-pushed
the
lkysow/service-account-err
branch
from
0b76bf0
to
b71595f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If consul login fails when the service account name is
defaultthengive an explicit warning that the reason it failed is because in
default installations that is not a support service account name.
We can't fail during injection because we support modifying the binding
rule such that
defaultis a valid svc account name.Fixes #574
How I've tested this PR:
Checklist: