Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resource config for ServiceInit #758

Merged
merged 7 commits into from
Oct 5, 2021
Merged

add resource config for ServiceInit #758

merged 7 commits into from
Oct 5, 2021

Conversation

mark-vw
Copy link
Contributor

@mark-vw mark-vw commented Oct 4, 2021

Changes proposed in this PR:

  • Congiure resource requests and limits for the service init container on the mesh gateway deployment.

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 4, 2021

CLA assistant check
All committers have signed the CLA.

yq selector was incorrect
@david-yu
Copy link
Contributor

david-yu commented Oct 5, 2021

Hi @mark-vw thanks for the PR! Could you let us know when you think this PR is ready for review?

@mark-vw
Copy link
Contributor Author

mark-vw commented Oct 5, 2021 via email

Update default values to the original values defined in mesh-gateway-deployment.yaml
@mark-vw mark-vw marked this pull request as ready for review October 5, 2021 17:23
@mark-vw
Copy link
Contributor Author

mark-vw commented Oct 5, 2021

@david-yu, this is now ready for review.

Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a suggestion to simplify the templating.

No need for string-based config support as this is a new setting
@lkysow lkysow merged commit 57fc0c9 into hashicorp:main Oct 5, 2021
lkysow added a commit that referenced this pull request Oct 5, 2021
lkysow added a commit that referenced this pull request Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants