Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix installing helm prerequisite #753

Merged
merged 2 commits into from
Sep 30, 2021
Merged

ci: fix installing helm prerequisite #753

merged 2 commits into from
Sep 30, 2021

Conversation

ndhanushkodi
Copy link
Contributor

@ndhanushkodi ndhanushkodi commented Sep 30, 2021 •
edited
Loading

Changes proposed in this PR:

How I've tested this PR:
acceptance tests should go green

How I expect reviewers to test this PR:
acceptance tests should go green

@ndhanushkodi ndhanushkodi marked this pull request as ready for review September 30, 2021 20:00
lkysow
lkysow approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@lkysow lkysow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol why did we have the other install as well :notsure: - oh nvm, was just looking at half the diff

@ndhanushkodi ndhanushkodi requested review from a team, ishustava and thisisnotashwin and removed request for a team and ishustava September 30, 2021 20:55
thisisnotashwin
thisisnotashwin approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ thank you!!

@ndhanushkodi ndhanushkodi merged commit 6254b1f into main Sep 30, 2021
@ndhanushkodi ndhanushkodi deleted the fix-helm-prereq branch September 30, 2021 21:14
lawliet89 pushed a commit to lawliet89/consul-k8s that referenced this pull request Oct 6, 2021
@ishustava
Add docs gen annotations to resource settings (hashicorp#753)
2bc2f54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkysow lkysow lkysow approved these changes

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndhanushkodi @lkysow @thisisnotashwin