Default to excluding system ns's from injection #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
force-pushed
the
lkysow/kube-system-exclusion
branch
from
753ce76
to
344428d
Compare
lawliet89
pushed a commit
to lawliet89/consul-k8s
that referenced
this pull request
Oct 6, 2021
lkysow
force-pushed
the
lkysow/kube-system-exclusion
branch
from
344428d
to
fd27556
Compare
lkysow
force-pushed
the
lkysow/kube-system-exclusion
branch
from
7b8dd6e
to
d63d83b
Compare
lkysow
requested review from
a team,
ndhanushkodi and
thisisnotashwin
and removed request for
a team
|
I think the tests are failing because they're not using the actual chart changes in this PR. |
kube-system is excluded because it's unlikely users will want to provision Connect pods in that namespace and also because we don't want to block pods being provisioned there if our webhook injector is down. local-path-storage is excluded because this ns is used by kind to provision PVCs and if ACLs are enabled then the install gets into a deadlock where: - PVC can't be provisioned because Kind needs to create a Pod - Pod can't be created because injector webhook needs to be up - injector webhook can't come up until its got an ACL token - ACL token can't be provisioned because Consul server isn't up - Consul server can't be started because it doesn't have a PVC NOTE: This matching is only supported in Kube 1.21+ where they've added these labels to namespaces automatically now.
lkysow
force-pushed
the
lkysow/kube-system-exclusion
branch
from
d63d83b
to
c3ad2f5
Compare
ndhanushkodi
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kube-system is excluded because it's unlikely users will want to
provision Connect pods in that namespace and also because we don't want
to block pods being provisioned there if our webhook injector is down.
local-path-storage is excluded because this ns is used by kind to
provision PVCs and if ACLs are enabled then the install gets into a
deadlock where:
NOTE: This matching is only supported in Kube 1.21+ where they've added
these labels to namespaces automatically now.
Should fix #715
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: