Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Consul version to 1.10.2 #718

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Bump Consul version to 1.10.2 #718

merged 1 commit into from
Sep 14, 2021

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Sep 10, 2021

  • Bump default Consul version to 1.10.2
  • fix tests that were failing due to a change in how the
    DestinationUpstream field is set in Consul OSS vs Enterprise.
  • set use_streaming_backend to false for Consul clients because
    streaming is not currently supported with mesh gateway federation

How I've tested this PR:

  • acceptance tests

How I expect reviewers to test this PR:

  • code

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@brunorochadasilva
Copy link

The world needs this PR @lkysow 😄

👍 in this PR even in draft.

lawliet89 pushed a commit to lawliet89/consul-k8s that referenced this pull request Sep 13, 2021
If the mesh gateway tests fail, the acceptance tests will now write two
files <PODNAME>-envoy-configdump.json and <PODNAME>envoy-clusters.json
which will have information from the envoy admin /config_dump endpoint
and /clusters endpoint.

Currently we write the outputs of `kubectl logs POD` and `kubectl describe
POD` for the acceptance tests, but while debugging EKS acceptance test
failures, it was hard to know from our existing logs whether the mesh
gateway itself is unreachable or if the consul servers behind it are
unhealthy. We'd be able to tell this from looking at the envoy config
dump and cluster config to see what envoy's view of the consul servers
are.
- fix tests that were failing due to a change in how the
DestinationUpstream field is set in Consul OSS vs Enterprise.
- set use_streaming_backend to false for Consul clients because
streaming is not currently supported with mesh gateway federation
@@ -24,7 +24,8 @@ data:
in the UI. */}}
config.json: |-
{
"check_update_interval": "0s"
"check_update_interval": "0s",
"use_streaming_backend": false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put this here because it only causes issues when doing federation and consul connect

@@ -543,7 +543,7 @@ load _helpers
#--------------------------------------------------------------------
# config-configmap

@test "client/DaemonSet: adds config-checksum annotation when extraConfig is blank" {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just re-worded the test titles a bit here because it always adds the config-checksum annotation so really what we're testing is that the checksum changes when the configmap is different

@lkysow lkysow marked this pull request as ready for review September 14, 2021 18:47
@lkysow lkysow requested review from a team, ishustava and t-eckert and removed request for a team September 14, 2021 18:47
@lkysow lkysow merged commit 10328ec into main Sep 14, 2021
@lkysow lkysow deleted the lkysow/consul-bump branch September 14, 2021 20:17
t-eckert pushed a commit that referenced this pull request Sep 17, 2021
- fix tests that were failing due to a change in how the
DestinationUpstream field is set in Consul OSS vs Enterprise.
- set use_streaming_backend to false for Consul clients because
streaming is not currently supported with mesh gateway federation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants