Update CHANGELOG.md #688
Merged
Update CHANGELOG.md #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
requested review from
a team,
thisisnotashwin and
t-eckert
and removed request for
a team
thisisnotashwin
approved these changes
Aug 26, 2021
|
Though one thing we should think about is whether the changelog sentences should be in present or past tense. They flip between them from bullet to bullet. |
Yeah good point. Which one do you think makes most sense? |
|
Personally, I prefer the present tense. |
I agree. I tend to read changelogs like: This update... adds support for just going wild and doing a flip. This is how the service will behave when I update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.