Allow unstructured schema for the ProxyDefaults CRD #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
thisisnotashwin
approved these changes
Apr 20, 2021
ishustava
requested review from
a team,
lkysow and
kschoche
and removed request for
a team and
kschoche
ishustava
added a commit
to hashicorp/consul-helm
that referenced
this pull request
Apr 20, 2021
Prior to apiextensions.k8s.io/v1, structured schema was optional for CRD spec, but now it is required. Since config field can have arbitrary keys, we need to tell Kubernetes to allow that explicitly now that we've upgraded from v1beta1 to v1. * Update CRD schema for ProxyDefaults based on new generated code from hashicorp/consul-k8s#495 * Update acceptance test for proxy defaults to set all possible fields. For the config field, we're not setting all acceptable values but I think it's OK since we're trying to check that at least one is accepted by Consul.
ndhanushkodi
pushed a commit
to ndhanushkodi/consul-k8s
that referenced
this pull request
Jul 9, 2021
…ork-with-acls Update helm test to validate successful installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to
apiextensions.k8s.io/v1, structured schema was optional for CRD spec, but now it is required. Sinceconfigfield can have arbitrary keys, we need to tell Kubernetes to allow that explicitly now that we've upgraded fromv1beta1tov1.Changes proposed in this PR:
x-kubernetes-preserve-unknown-fieldstotruefor theconfigfield inProxyDefaultsHow I've tested this PR:
by running acceptance tests
How I expect reviewers to test this PR:
code review (acceptance tests in hashicorp/consul-helm#921)
Checklist: