Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental] Use privileged dataplane entrypoint for ingress-gateway #4394

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

nathancoleman
Copy link
Member

@nathancoleman nathancoleman commented Oct 17, 2024

Note

This PR has a dependency on hashicorp/consul-dataplane#652

Changes proposed in this PR

  • Ingress gateways, which have historically supported binding to privileged ports, use the new "privileged" entrypoint for dataplane which still requires the NET_BIND_SERVICE capability at runtime
  • All other use cases for dataplane now use the "unprivileged" entrypoint which does not require the NET_BIND_SERVICE capability at runtime

How I've tested this PR

Verify functionality for service mesh with ingress, API, mesh and terminating gateways on both:

  • Vanilla kubernetes
  • OpenShift

How I expect reviewers to test this PR

See above

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport signals that a PR will not contain a backport label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants