[NET-11150] ci: fix conditional skip and add safeguard #4363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalimeni
added
backport/1.1.x
zalimeni
requested review from
rboyer,
jm96441n,
NiniOak and
sarahalsmiller
zalimeni
commented
Sep 25, 2024
| @@ -12,13 +12,58 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
There was a problem hiding this comment.
No updates needed to triggers in calling workflows, as they were already split on PR and protected branch push.
zalimeni
commented
Sep 25, 2024
Comment on lines
+48
to
+52
| .copywrite.hcl | ||
| .gitignore | ||
| **.md | ||
| assets/** |
There was a problem hiding this comment.
These are the only changed lines from the original dataplane PR.
zalimeni
force-pushed
the
zalimeni/fix-ci-skip-action
branch
from
20c6e08
to
230cc21
Compare
Adopt a third-party action to avoid script bugs, and to fix a current issue where the script fails to detect all changes when processing push events on PR branches. Adapted from hashicorp/consul-dataplane#637. See that PR for testing details and background context.
zalimeni
force-pushed
the
zalimeni/fix-ci-skip-action
branch
from
230cc21
to
93e8afe
Compare
NiniOak
approved these changes
Sep 25, 2024
This was referenced Sep 25, 2024
This was referenced Sep 25, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt a third-party action to avoid script bugs, and to fix a current issue where the script fails to detect all changes when processing push events on PR branches.
Adapted from hashicorp/consul-dataplane#637. See that PR for testing details and background context.
How I've tested this PR
See hashicorp/consul-dataplane#637 and conditional skip output in this PR's checks.
How I expect reviewers to test this PR
👀
Checklist