Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [NET-6466] Remove secrets from termgw role into release/1.3.x #3946

Conversation

hc-github-team-consul-core

Backport

This PR is auto-generated from #3928 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@jm96441n
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: unable to process merge commit: "d5c39d918b1f8e3caec230cd43779fd86bb8c061", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Changes proposed in this PR

  • remove secrets access from terminating gateway as this is no longer needed

How I've tested this PR

  1. build a local version of the control plane by running make dev-docker from the root of this repo
  2. clone the following gist https://gist.github.com/jm96441n/8671cc5e73bf950955c96f7cd3281694
  3. checkout this branch in consul-k8s repo on your machine
  4. in start.sh replace the value for CONSUL_K8S_CHART_LOCATION with the path to the helm charts in consul-k8s on your system
  5. run start.sh
  6. once all the services are up exec into the bender service using:
kubectl exec -i -t $(kubectl get pods --selector=app=bender -o jsonpath='{.items[*].metadata.name}') -c bender -- /bin/sh
  1. install curl onto the container using apk add curl
  2. contact the zoidberg service fronted by the termgw using curl zoidberg.virtual.consul

How I expect reviewers to test this PR

Read the code, follow the above steps

Checklist


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/NET-6466-remove-access-to-secrets-for-termgw/internally-deep-guinea branch from 282e58b to cf35c93 Compare April 22, 2024 21:07
@jm96441n jm96441n marked this pull request as ready for review April 23, 2024 15:52
@jm96441n jm96441n enabled auto-merge (squash) April 23, 2024 15:53
@jm96441n jm96441n merged commit 648ed54 into release/1.3.x Apr 23, 2024
25 of 50 checks passed
@jm96441n jm96441n deleted the backport/NET-6466-remove-access-to-secrets-for-termgw/internally-deep-guinea branch April 23, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants