Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown Subcommands with SIGTERM and SIGINT #389

Merged
merged 10 commits into from
Nov 14, 2020
Merged

Shutdown Subcommands with SIGTERM and SIGINT #389

merged 10 commits into from
Nov 14, 2020

Commits on Nov 11, 2020

  1. Shutdown Connect Lifecycle Sidecar with SIGTERM 

    - Kubernetes sends SIGTERM to shut down containers.
- Other tools like Argo also adopts the same behaviour to shut
container down
- Connect Lifecycle Sidecar should also listen to SIGTERM for shutting
down
    @lawliet89
    lawliet89 committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    30ea4a8 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. Update subcommand/lifecycle-sidecar/command.go 

    Co-authored-by: Ashwin Venkatesh <ashwin.what@gmail.com>
    @lawliet89 @thisisnotashwin
    lawliet89 and thisisnotashwin authored Nov 12, 2020
    Configuration menu
    Copy the full SHA
    649a6a2 View commit details
    Browse the repository at this point in the history

  2. Add SIGTERM handling to more subcommands

    @lawliet89
    lawliet89 committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    ead19ff View commit details
    Browse the repository at this point in the history

  3. Add tests 

    - Fix logging and add test for lifecycle-sidecar
    @lawliet89
    lawliet89 committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    855da2b View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. Add check for exit 

    - 10s for sync catalog since it needs more time
    @lawliet89
    lawliet89 committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    c54699e View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2020

  1. Update subcommand/inject-connect/command_test.go 

    Co-authored-by: Ashwin Venkatesh <ashwin.what@gmail.com>
    @lawliet89 @thisisnotashwin
    lawliet89 and thisisnotashwin authored Nov 14, 2020
    Configuration menu
    Copy the full SHA
    55e50b1 View commit details
    Browse the repository at this point in the history

  2. Remove goimports changes

    @lawliet89
    lawliet89 committed Nov 14, 2020
    Configuration menu
    Copy the full SHA
    679275f View commit details
    Browse the repository at this point in the history

  3. Undo stopCommand changes

    @lawliet89
    lawliet89 committed Nov 14, 2020
    Configuration menu
    Copy the full SHA
    198d3de View commit details
    Browse the repository at this point in the history

  4. Change to 5s and add explanation

    @lawliet89
    lawliet89 committed Nov 14, 2020
    Configuration menu
    Copy the full SHA
    68878b3 View commit details
    Browse the repository at this point in the history

  5. Reduce changes in webhook cert manager command

    @lawliet89
    lawliet89 committed Nov 14, 2020
    Configuration menu
    Copy the full SHA
    4bba5a1 View commit details
    Browse the repository at this point in the history